Repository navigation
Load contract state files in tests with the full state size - #1059
Open
fnordspace wants to merge 1 commit into
Open
fnordspace wants to merge 1 commit into
fnordspace wants to merge 1 commit into
Conversation
cyber-pc
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QX and QSWAP test fixtures loaded state files with
sizeof(QX)/sizeof(QSWAP). Since state moved toStateData, those classes are empty (sizeof= 1), soloadState()read 1 byte, returnedtrue, and the tests ran on an empty state.ContractQx.BugEntityBidOrdersandContractQx.CleanupCollectionspassed without testing anything.ContractTesting::loadContractState(). It takes the size fromcontractDescriptionsand only loads a file whose size matches exactly; otherwise the test skips and prints the actual and expected sizes.